PERF/REGR: IntervalIndex.intersection, PeriodIndex.get_loc #42293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Interval
Closed
|
looks good can u run the asvs on these to see the change |
|
backporting in any event |
jreback
approved these changes
Jun 29, 2021
| # -------------------------------------------------------------------- | ||
| # Set Operations | ||
|
|
||
| def _intersection(self, other, sort): |
There was a problem hiding this comment.
you could probably do this more generally (e.g. push it down into Index itself). but of course for later.
| elif isinstance(key, Period): | ||
| pass | ||
| sfreq = self.freq |
There was a problem hiding this comment.
could codify in a method (the comparison) but nbd (for later)
This comment has been minimized.
This comment has been minimized.
|
@meeseeksdev backport 1.3.x |
|
@jbrockmendel needs a manual backport |
This comment has been minimized.
This comment has been minimized.
This was referenced Jun 29, 2021
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Jun 29, 2021
…PeriodIndex.get_loc
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #42240, #42247, not checking the box because I jumped the gun last time.